Re: [PATCH] locking: remove three unused Kconfig symbols

[Paul Bolle]

On Mon, 2013-04-08 at 17:16 +0200, Ingo Molnar wrote:
> * Paul Bolle <pebolle@xxxxxxxxxx> wrote:
> > The Kconfig symbols ARCH_INLINE_READ_UNLOCK_IRQ,
> > ARCH_INLINE_SPIN_UNLOCK_IRQ, and ARCH_INLINE_WRITE_UNLOCK_IRQ were added
> > in v2.6.33, but have never actually been used. It is safe to remove
> > these.
> > 
> Erm, if you look at the code in question you'll see that they are unused I think 
> due to a bug:
> 
>  config INLINE_READ_UNLOCK_IRQ
>         def_bool y
>         depends on !PREEMPT || ARCH_INLINE_READ_UNLOCK_BH
> 
> Shouldn't that depend on ARCH_INLINE_READ_UNLOCK_IRQ?
> 
> Similarly for the others.

Yes, that seems correct. I must admit that I didn't spot that
possibility, but then again this Kconfig file is near unreadable (too
much repetition for human readers).

Would you have any idea why this problem wasn't noticed in 16 (!)
releases? Fedora 17, which I did this patch on, has Kconfig symbolk
PREEMPT not set. Is it perhaps commit to not enable that option?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/