Re: [PATCH] usb: xhci-dbg: Display endpoint number and direction incontext dump

[Sarah Sharp]

On Thu, Apr 04, 2013 at 02:03:04PM -0700, Julius Werner wrote:
> When CONFIG_XHCI_HCD_DEBUGGING is activated, the XHCI driver can dump
> device and input contexts to the console. The endpoint contexts in that
> dump are labeled "Endpoint N Context", where N is DCI - 1... this is
> very confusing, especially for people who are not that familiar with
> the XHCI specification. Let's change this to display the endpoint number
> and direction, which are much more commonly used concepts in USB (and
> map to XHCI DCIs 1-to-1).

Thanks for the patch, I think it's a good idea, however...

> Signed-off-by: Julius Werner <jwerner@xxxxxxxxxxxx>
> ---
>  drivers/usb/host/xhci-dbg.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
> index 5f3a7c7..98b1bee 100644
> --- a/drivers/usb/host/xhci-dbg.c
> +++ b/drivers/usb/host/xhci-dbg.c
> @@ -507,7 +507,8 @@ static void xhci_dbg_ep_ctx(struct xhci_hcd *xhci,
>  		dma_addr_t dma = ctx->dma +
>  			((unsigned long)ep_ctx - (unsigned long)ctx->bytes);
>  
> -		xhci_dbg(xhci, "Endpoint %02d Context:\n", i);
> +		xhci_dbg(xhci, "Endpoint %02d %s Context:\n",
> +				DIV_ROUND_UP(i, 2), i % 2 ? "OUT" : "IN");

...could you create two macros in xhci.h to translate the xHCI endpoint
context number to USB formated endpoint numbers, and IN vs. OUT?  I
suspect that there will be other places in the code where you'll want to
print the USB formatted endpoint numbers.  Having macros for later use
would be helpful.

Also, this patch is too late for the 3.10 merge window, so it will
have to wait for 3.11.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/