Re[2]: linux-next: build failure after merge of the mfd tree
From: Alexander Shiyan
Date: Mon Apr 08 2013 - 12:27:58 EST
> > > After merging the mfd tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
> > > drivers/regulator/anatop-regulator.c:134:2: error: implicit declaration of function 'of_get_parent' [-Werror=implicit-function-declaration]
> > >
> > > Caused by commit 5ab3a89a741f ("mfd: syscon: Add non-DT support").
> > >
> > > I have used the mfd tree from next-20130405 for today.
> >
> > This means that we do not have empty declarations for the
> > of_xx functions in linux/of.h for !CONFIG_OF.
> > OK to declare these functions or any other opinions?
> Ok with me, but you'd need to get Grant and Rob's ACK.
I've revised my initial opinion and write ââa quick patch for fix this issue.
From a884d309d2978cbc44c52b650d669e56fef664e2 Mon Sep 17 00:00:00 2001
From: Alexander Shiyan <shc_work@xxxxxxx>
Date: Mon, 8 Apr 2013 19:13:10 +0400
Subject: [PATCH] regulator: anatop: Make select dependency from
HAVE_IMX_ANATOP symbol
This patch make selection of anatop-regulator from HAVE_IMX_ANATOP
kernel symbol. This fixes build kernel with syscon driver but without
oftree support.
Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
---
drivers/regulator/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index a5d97ea..078932d 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -133,7 +133,7 @@ config REGULATOR_FAN53555
config REGULATOR_ANATOP
tristate "Freescale i.MX on-chip ANATOP LDO regulators"
- depends on MFD_SYSCON
+ depends on HAVE_IMX_ANATOP
help
Say y here to support Freescale i.MX on-chip ANATOP LDOs
regulators. It is recommended that this option be
--
1.8.1.5
---
¢éì®&Þ~º&¶¬+-±éÝ¥w®Ë±Êâmébìdz¹Þ)í
æèw*jg¬±¨¶Ýj/êäz¹Þà2Þ¨èÚ&¢)ß«a¶Úþø®G«éh®æj:+v¨wèÙ>W±êÞiÛaxPjØm¶ÿÃ-»+ùd_