Re: [PATCH 3/3] mm: when handling percpu_pagelist_fraction, use on_each_cpu()to set percpu pageset fields.

From: Cody P Schafer
Date: Mon Apr 08 2013 - 13:35:27 EST


On 04/06/2013 06:56 PM, Simon Jeons wrote:
Hi Cody,
On 04/06/2013 04:33 AM, Cody P Schafer wrote:
In free_hot_cold_page(), we rely on pcp->batch remaining stable.
Updating it without being on the cpu owning the percpu pageset
potentially destroys this stability.

If cpu is off, can its pcp pageset be used in free_hot_code_page()?


I don't expect it to be as we use this_cpu_ptr() to access the pcp pageset. Unless there is some crazy mode where we can override the cpu a task believes it is running on...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/