Re: [PATCHv3, RFC 32/34] thp: handle write-protect exception to file-backedhuge pages

[Dave Hansen]

For all the do_huge_pmd_wp_page(), I think we need a better description
of where the code came from.  There are some more obviously
copy-n-pasted comments in there.

For the entire series, in the patch description, we need to know:
1. What was originally written and what was copied from elsewhere
2. For the stuff that was copied, was an attempt made to consolidate
   instead of copy?  Why was consolidation impossible or infeasible?

> +			if (!PageAnon(page)) {
> +				add_mm_counter(mm, MM_FILEPAGES, -HPAGE_PMD_NR);
> +				add_mm_counter(mm, MM_ANONPAGES, HPAGE_PMD_NR);
> +			}

This seems like a bit of a hack.  Shouldn't we have just been accounting
to MM_FILEPAGES in the first place?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/