Re: [PATCH v8 1/3] mm: limit growth of 3% hardcoded other userreserve

From: Andrew Morton
Date: Mon Apr 08 2013 - 15:34:40 EST


On Mon, 8 Apr 2013 15:04:02 -0400 Andrew Shewmaker <agshew@xxxxxxxxx> wrote:

> v8:
> * Rebased onto v3.9-rc4-mmotm-2013-03-26-15-09
>
> * Clarified reasoning between different calculations for
> overcommit 'guess' and 'never modes in FAQ entry
> "How do you calculate a minimum useful reserve?"
> in response to Simon Jeons.
>
> * Added third patch in series to handle hot-added or hot-swapped
> memory.

Well here's the v7-plus-my-fixes to v8 delta:

--- a/.gitignore~mm-limit-growth-of-3%-hardcoded-other-user-reserve-v8
+++ a/.gitignore
@@ -30,6 +30,7 @@ modules.builtin
*.lzma
*.xz
*.lzo
+*.out
*.patch
*.gcno

diff -puN include/linux/mm.h~mm-limit-growth-of-3%-hardcoded-other-user-reserve-v8 include/linux/mm.h
--- a/include/linux/mm.h~mm-limit-growth-of-3%-hardcoded-other-user-reserve-v8
+++ a/include/linux/mm.h
@@ -44,8 +44,6 @@ extern int sysctl_legacy_va_layout;
#include <asm/pgtable.h>
#include <asm/processor.h>

-extern unsigned long sysctl_user_reserve_kbytes;
-
#define nth_page(page,n) pfn_to_page(page_to_pfn((page)) + (n))

/* to align the pointer to the (next) page boundary */
diff -puN kernel/sysctl.c~mm-limit-growth-of-3%-hardcoded-other-user-reserve-v8 kernel/sysctl.c
--- a/kernel/sysctl.c~mm-limit-growth-of-3%-hardcoded-other-user-reserve-v8
+++ a/kernel/sysctl.c
@@ -97,6 +97,7 @@
/* External variables not in a header file. */
extern int sysctl_overcommit_memory;
extern int sysctl_overcommit_ratio;
+extern unsigned long sysctl_user_reserve_kbytes;
extern int max_threads;
extern int suid_dumpable;
#ifdef CONFIG_COREDUMP

ie, it reverts my cleanup of the extern declaration and adds a random
unchangelogged line to .gitignore.

I'll grab the new changelog then ignore this update ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/