Re: [PATCH] Convert compat_sys_sysinfo to COMPAT_SYSCALL_DEFINE

From: Andrew Morton
Date: Mon Apr 08 2013 - 17:36:00 EST


On Mon, 8 Apr 2013 14:56:16 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:

> --- a/kernel/timer.c
> +++ b/kernel/timer.c
> @@ -1661,8 +1661,7 @@ struct compat_sysinfo {
> char _f[20-2*sizeof(u32)-sizeof(int)];
> };
>
> -asmlinkage long
> -compat_sys_sysinfo(struct compat_sysinfo __user *info)
> +COMPAT_SYSCALL_DEFINE1(sysinfo, struct compat_sysinfo __user *, info)

wtflol.

akpm3:/usr/src/25> grep SYSCALL kernel/timer.c
SYSCALL_DEFINE1(alarm, unsigned int, seconds)
SYSCALL_DEFINE0(getpid)
SYSCALL_DEFINE0(getppid)
SYSCALL_DEFINE0(getuid)
SYSCALL_DEFINE0(geteuid)
SYSCALL_DEFINE0(getgid)
SYSCALL_DEFINE0(getegid)
SYSCALL_DEFINE0(gettid)
SYSCALL_DEFINE1(sysinfo, struct sysinfo __user *, info)
COMPAT_SYSCALL_DEFINE1(sysinfo, struct compat_sysinfo __user *, info)

Only one of those should be in kernel/timer.c. Who wrote this thing?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/