Re: [PATCH v3 0/7] f2fs: add tracepoints support in f2fs filesystem

From: Steven Rostedt
Date: Mon Apr 08 2013 - 20:25:24 EST


On Sat, 2013-04-06 at 14:45 +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>
> Add tracepoints in f2fs filesystem for tracing the filesystem
> operations for information/debugging purpose if needed. All the
> tracepoints are clubbed with respect to functionalities.
>
> Change Log:
> v3: Introduced TRACE_EVENT_CONDITION() macro for checking the
> condition page->mapping inside the trace point function call as
> per Steve's review comment for the patch
>
> v2: Added DECLARE_EVENT_CLASS() macro for combining the similar
> type of trace function calls which has same type of arguments.
>
> v1: Introduced the tracepoint functions in f2fs filesystem.
>
> Namjae Jeon (7):
> f2fs: add tracepoints for sync & Inode operations
> f2fs: add tracepoints for truncate operation
> f2fs: add tracepoint for tracing the page i/o operations
> f2fs: add tracepoints for GC threads
> f2fs: add tracepoints to debug the block allocation & fallocate
> f2fs: add tracepoints for write page operations
> f2fs: add tracepoints to debug checkpoint request
>

I have nothing more to add about the tracepoint processing. Looks good.
Now if the tracepoints give you sufficient data? That's up to the
maintainers to decide.

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/