[PATCH] of: remove the unnecessary of_node_put for of_parse_phandle_with_args()

From: Yuantian.Tang
Date: Tue Apr 09 2013 - 03:34:57 EST


From: Tang Yuantian <yuantian.tang@xxxxxxxxxxxxx>

As the function itself says it is caller's responsibility to call the
of_node_put(). So, remove it on success to keep the reference count
correct.

Signed-off-by: Tang Yuantian <Yuantian.Tang@xxxxxxxxxxxxx>
---
drivers/of/base.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 321d3ef..e8b4c28 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1168,9 +1168,6 @@ static int __of_parse_phandle_with_args(const struct device_node *np,
out_args->args[i] = be32_to_cpup(list++);
}

- /* Found it! return success */
- if (node)
- of_node_put(node);
return 0;
}

--
1.8.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/