Re: [PATCH 3/4] gpio: Kontron PLD gpio driver

[Linus Walleij]

On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
<kevin.strasser@xxxxxxxxxxxxxxx> wrote:

> From: Michael Brunner <michael.brunner@xxxxxxxxxxx>
>
> Add gpio support for the on-board PLD found on some Kontron embedded
> modules.
>
> Signed-off-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>
> Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>

This looks very generic, setting and clearing bits in bytesized
registers.

Can you please attempt to use generic GPIO for this?

drivers/gpio/gpio-generic.c
<linux/basic_mmio_gpio.h>

See for example:
gpio-ep93xx.c, gpio-sodaville.c ...

Since you don't even have IRQ support in this it will be even simpler.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/