Re: kdb: kgdb: CONFIG_DEBUG_RODATA setting?

[Jason Wessel]

On 04/09/2013 08:06 AM, Sedat Dilek wrote:

>  config DEBUG_RODATA
>  	bool "Write protect kernel read-only data structures"
> -	default y
>  	depends on DEBUG_KERNEL
> +	default n if KGDB
> +	default y
>  	---help---
>  	  Mark the kernel read-only data as write-protected in the pagetables,
>  	  in order to catch accidental (and incorrect) writes to such const


This is wrong and should not be merged.

A) You should not change these defaults in this manner

B) You have pointed out that the documentation is currently
   incorrect. The CONFIG_DEBUG_RODATA constraints were removed some time
   ago, per commit 3751d3e85cf693e10e2c47c03c8caa65e171099b (x86,kgdb:
   Fix DEBUG_RODATA limitation using text_poke())

Jason.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/