Re: [PATCH 4/4] uprobes/tracing: generalize structuprobe_trace_entry_head

[Steven Rostedt]

On Tue, 2013-04-09 at 16:50 +0200, Oleg Nesterov wrote:
> On 04/08, Steven Rostedt wrote:

> OK, will do.
> 
> Or. Instead of enum we can use "bool is_return". So, instead of
> 
> 	if (is_ret_probe(tu))
> 		size = SIZEOF_TRACE_ENTRY(UPROBE_ENTRY_RETPROBE);
> 	else
> 		size = SIZEOF_TRACE_ENTRY(UPROBE_ENTRY_NORMAL);
> 
> we can do
> 
> 	size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
> 
> What do you like more?

Which ever is easier ;-)

I just hated the magic "1" and "2". As long as I (or any reviewer) does
not need to go searching for numbers, and can easily figure out what is
going on by looking at the code at hand, I'm happy.

Both the above satisfy that requirement.

Your "is_ret_probe(tu)" may have the added bonus of being less error
prone.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/