Re: [RT LATENCY] 249 microsecond latency caused by slub'sunfreeze_partials() code.

From: Steven Rostedt
Date: Wed Apr 10 2013 - 10:09:19 EST


On Wed, 2013-04-10 at 14:00 +0000, Christoph Lameter wrote:
> On Wed, 10 Apr 2013, Joonsoo Kim wrote:
>
> > > Christoph, Joonsoo, comments?
> >
> > Steven's comment is reasonable to me.
> >
> > If there is no objection from Christoph,
> > let's drop a patch in which I implement Christoph's idea.
>
> Fine with me.
>
> I do not like passing a reference just because we have to
> return an additional counter. Adds a lot of overhead.
>

The reference is only passed to acquire_slab() which is a static inline
function that's only called by this function. You would think that gcc
can optimize that to remove the "lot of overhead".

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/