Re: [PATCH 06/18] compat: backport ASYNC_DOMAIN_EXCLUSIVE()

From: Luis R. Rodriguez
Date: Wed Apr 10 2013 - 13:26:43 EST


On Wed, Apr 10, 2013 at 10:20 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Wed, 2013-04-10 at 10:13 -0700, Luis R. Rodriguez wrote:
>> On Wed, Apr 10, 2013 at 6:22 AM, Johannes Berg
>> <johannes@xxxxxxxxxxxxxxxx> wrote:
>> > On Wed, 2013-04-10 at 04:35 -0700, Luis R. Rodriguez wrote:
>> >> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>
>> >>
>> >> For older kernels this is simply a matter of using
>> >> LIST_HEAD.
>> >
>> > Hmm, how is that useful if it will not have any effect?
>>
>> The core of the handling is done in the internal asynch code and
>> that's kept hidden from the users of this -- so far.
>
> I guess I'd have to review the async API,

Yeap, reviewing the commit noted would help too.

> but now this wouldn't do
> anything?

Nope.

> What's the use of just this when you don't have things like
> async_schedule_domain() and async_synchronize_full_domain(), regulator
> stuff wouldn't compile I think?

You mean is not having the full asynch that deals with all registered
domains likely to have an issue on the useres of
async_synchronize_full_domain() ? Lets better ask Dan.

> I guess I'm a bit confused what kind of effect this has.

Nothing, really. If we had a user of it in other ways we'd fail
compiling anyway but right now its a simple direct replacement.

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/