Re: [PATCH RESEND v2 1/1] ARM Feroceon: fix kexec by setting outer_cache.inv_all

From: Elijah Ragozin
Date: Wed Apr 10 2013 - 14:43:41 EST


On 10.04.2013 19:48, Jason Cooper wrote:
On Mon, Apr 08, 2013 at 10:34:07PM +0300, Elijah Ragozin wrote:
On Feroceon the L2 cache becomes non-coherent with the CPU
when the L1 caches are disabled. Thus the L2 needs to be invalidated
after both L1 caches are disabled.

On kexec before the starting the code for relocation the kernel,
the L1 caches are disabled in cpu_froc_fin (cpu_v7_proc_fin for Feroceon),
but after L2 cache is never invalidated, because inv_all is not set
in cache-feroceon-l2.c.
So kernel relocation and decompression may has (and usually has) errors.
Setting the function enables L2 invalidation and fixes the issue.

Signed-off-by: Illia Ragozin <illia.ragozin@xxxxxxxxxxxx>
---
arch/arm/mm/cache-feroceon-l2.c | 1 +
1 file changed, 1 insertion(+)
fwiw,

Acked-by: Jason Cooper <jason@xxxxxxxxxxxxxx>

Please put this in Russell King's patch tracker so he can pull it in.

thx,

Jason.


Jason,

thank you for reviewing and acking,
I just put the patch to the Russell King's patch tracker.

--
Best Regards,
Illia Ragozin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/