Re: [PATCH 1/7] x86: don't show trace beyond show_stack(NULL, NULL)

From: Tejun Heo
Date: Wed Apr 10 2013 - 14:54:28 EST


On Wed, Apr 10, 2013 at 12:35:08PM +0200, Ingo Molnar wrote:
> Ok - but my other observation probably holds, that the bp == 0 special case in
> dump_trace() should be changed to a [printk()-ed] warning or so? No user will pass
> in bp == 0 legitimately, AFAICS.

Yeah, seems so. I'll verify and add a warning message if both @bp and
@regs aren't specified in dump_trace().

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/