Re: [PATCH] USB: ehci-omap: Select USB_PHY

[Alexander Holler]

Am 11.04.2013 16:44, schrieb Roger Quadros:

> > Sorry, but this just will end up with many users having broken configs
> > because of disabled stuff they don't know why they have to enable them.
> > And thus with a never ending stream of questions and thus with a needed
> > FAQ entry.
>
> Alexander,
>
> I agree with you that it can get difficult with users. But it is best for
> users do not disable anything they are not familiar with.
>
> As the USB_PHY option doesn't depend on anything, it is safe to select it
> from USB_EHCI_HCD_OMAP.
>
> However, the PHY drivers themselves must be selected from the board configs.

Maybe I understood something wrong, but if the OMAP USB driver requires 
CONFIG_USB_PHY (or similiar), it should be selected automatically and 
not just enabled in the board config.

I just had it to often, that I needed to search around why a driver 
doesn't work (or even compiles), just to find out that I need to enable 
some strange config option which wasn't selected automatically. 
Especially with OMAPs. ;)

And this not only occured when disabling options, it often occured by 
just updating the kernel. Suddenly some obscur option was needed too, it 
wasn't selected automatically by make oldconfig, bang. So the argument 
to not remove anything from a board config doesn't help much.

Sorry for the rant. ;)

Regards,

Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/