Re: [PATCH] vhost_net: remove tx polling state

From: David Miller
Date: Thu Apr 11 2013 - 16:17:26 EST


From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
Date: Thu, 11 Apr 2013 10:24:30 +0300

> On Thu, Apr 11, 2013 at 02:50:48PM +0800, Jason Wang wrote:
>> After commit 2b8b328b61c799957a456a5a8dab8cc7dea68575 (vhost_net: handle polling
>> errors when setting backend), we in fact track the polling state through
>> poll->wqh, so there's no need to duplicate the work with an extra
>> vhost_net_polling_state. So this patch removes this and make the code simpler.
>>
>> This patch also removes the all tx starting/stopping code in tx path according
>> to Michael's suggestion.
>>
>> Netperf test shows almost the same result in stream test, but gets improvements
>> on TCP_RR tests (both zerocopy or copy) especially on low load cases.
>>
>> Tested between multiqueue kvm guest and external host with two direct
>> connected 82599s.
...
>> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
>
> Less code and better speed, what's not to like.
> Davem, could you pick this up for 3.10 please?
>
> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Applied to net-next, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/