Re: [PATCH v4 21/22] x86, mm: Make init_mem_mapping be able to becalled several times

From: Yinghai Lu
Date: Thu Apr 11 2013 - 22:04:25 EST


On Thu, Apr 11, 2013 at 6:05 PM, Konrad Wilk <konrad.wilk@xxxxxxxxxx> wrote:
>
> ----- yinghai@xxxxxxxxxx wrote:
>
>> Prepare to put page table on local nodes.
>>
>> Move calling of init_mem_mapping to early_initmem_init.
>>
>> Rework alloc_low_pages to alloc page table in following order:
>> BRK, local node, low range
>>
>> Still only load_cr3 one time, otherwise we would break xen 64bit
>> again.
>
> I have asked you in the previous iteration of the patch to fix that comment.

Maybe it is not clear enough.

>
> Please remove it - as it is misleading. The issue with load_cr3 more than
> once has been fixed under the Xen platform.

Peter, can you remove those two lines?
or need to resend -v5?

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/