Re: [PATCH 5/6] tools lib traceevent: Add page_size field to pevent

[Namhyung Kim]

2013-04-12 (ê), 22:14 -0400, Steven Rostedt:
> On Sat, 2013-04-13 at 11:08 +0900, Namhyung Kim wrote:
> > 2013-04-12 (ê), 21:26 -0400, Steven Rostedt:
> 
> > I think it only affects trace-cmd as it's the only user that accesses
> > raw ring-buffer contents for now.  I found it during writing code also
> > accesses the ring buffer (with kbuffer code) - perf ftrace. :)
> > 
> > But the code is in a very early stage and needs to handle so many things
> > before posting to the list.  So I just wanted to post a part of the
> > preparation first.
> 
> I understand. But people tend to not like things in upstream that has no
> user. If Arnaldo wants to include it, that's his decision. I'm just
> worried that if it takes a while before your other work gets mainline,
> people might start sending patches to remove that code and your stuff
> will suddenly break.

Fair enough.

Arnaldo, what do you think?  Do you want me to resend it with new
description now?

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/