Re: [PATCH tip/core/rcu 0/12] TINY_RCU changes for 3.11

[Paul E. McKenney]

On Sat, Apr 13, 2013 at 11:30:49AM -0700, Josh Triplett wrote:
> On Fri, Apr 12, 2013 at 04:48:10PM -0700, Paul E. McKenney wrote:
> > This series removes TINY_PREEMPT_RCU, as promised/threatened at
> > http://lwn.net/Articles/541037/ and https://lkml.org/lkml/2012/11/12/545.
> > 
> > 1.	Remove TINY_PREEMPT_RCU.  This is a straight syntactic removal,
> > 	with no attempt at cleanup.  The remaining patches do the cleanup.
> > 
> > 2.	Inline the now-empty show_tiny_preempt_stats() function.
> > 
> > 3.	Inline the now-empty rcu_preempt_check_callbacks() function.
> > 
> > 4.	Inline the now-empty rcu_preempt_remove_callbacks() function.
> > 
> > 5.	Inline the now-empty rcu_preempt_process_callbacks() function.
> > 
> > 6.	Because TINY_RCU no longer has kthreads, remove the code that
> > 	used to abstract away kthread vs. softirq invocation.
> > 
> > 7.	Inline the now-empty check_cpu_stall_preempt() function.
> > 
> > 8.	Remove CONFIG_TINY_RCU ifdefs from include/linux/rcutiny.h
> > 
> > 9.	Inline the now-empty rcu_preempt_note_context_switch() function.
> > 
> > 10.	Move code to allow consolidating ifdefs in kernel/rcutiny_plugin.h.
> > 
> > 11.	Remove TINY_PREEMPT_RCU's tracing formats from documentation.
> > 
> > 12.	Shrink TINY_RCU a bit by moving exit_rcu() to TREE_RCU, leaving
> > 	TINY_RCU with a static inline empty function.
> 
> For 2-7 and 9-12:
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> 
> I responded to patch 8 with a note about moving part of it to patch 1;
> with that changed,
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> for those two as well.

Thank you for the review, and good point on merging patch 8 into patch 1,
will do!

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/