Re: [RFC PATCH 0/2] sched: move content out of core files for load average

[Paul Gortmaker]

On Sat, Apr 13, 2013 at 12:30 AM, Rakib Mullick <rakib.mullick@xxxxxxxxx> wrote:
> On Sat, Apr 13, 2013 at 6:04 AM, Paul Gortmaker
> <paul.gortmaker@xxxxxxxxxxxxx> wrote:
>> Recent activity has had a focus on moving functionally related blocks of stuff
>> out of sched/core.c into stand-alone files.  The code relating to load average
>> calculations has grown significantly enough recently to warrant placing it in
>> a separate file.
>>
>> Here we do that, and in doing so, we shed ~20k of code from sched/core.c (~10%).

[...]

>> Paul Gortmaker (2):
>>   sched: fork load calculation code from sched/core --> sched/load_avg
>>   sched: move update_load_[add/sub/set] from sched.h to fair.c
>>
>>  kernel/sched/Makefile   |   2 +-
>>  kernel/sched/core.c     | 569 -----------------------------------------------
>>  kernel/sched/fair.c     |  18 ++
>>  kernel/sched/load_avg.c | 577 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  kernel/sched/sched.h    |  26 +--
>>  5 files changed, 604 insertions(+), 588 deletions(-)
>>  create mode 100644 kernel/sched/load_avg.c
>>
>
> Is there any impact positive over vmlinuz size after these changes?

As per the above description and diffstat, it is just a straight
up code relocation, so aside from trivial differences in what
the optimizer does, I'd expect no real change at all in the
size or anything else

Paul.
--

>
> Thanks,
> Rakib
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/