Re: [PATCH 2/4] i2c: Kontron PLD i2c bus driver

[Wolfram Sang]

On Wed, Apr 10, 2013 at 10:02:12AM -0700, Guenter Roeck wrote:
> On Mon, Apr 08, 2013 at 10:15:19AM -0700, Kevin Strasser wrote:
> > From: Michael Brunner <michael.brunner@xxxxxxxxxxx>
> > 
> > Add i2c support for the on-board PLD found on some Kontron embedded
> > modules.
> > 
> > Signed-off-by: Michael Brunner <michael.brunner@xxxxxxxxxxx>
> > Signed-off-by: Kevin Strasser <kevin.strasser@xxxxxxxxxxxxxxx>
> 
> Overall well written, though I have a couple of nitpicks.
> 
> I would prefer two separate drivers, one for the mux and one for the i2c bus.
> If that is possible, it would help getting rid of the #ifdef in the code, which
> is frowned upon in the kernel.
> 
> I dislike unnecessary ( ). Maintainer's call, though.
> 
> Couple of places have missing spaces around operators (checkpatch doesn't catch
> all those).
> 
> As far as I know, devm_ functions are supposed to print an error message on
> failure, so it should be unnecessary to print another one if that happens (this
> might need some confirmation).

Haven't done a full review due to tglx NACK. I agree to the points
mentioned here by Guenter, though.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/