RE: [PATCH v2] of/base: release the node correctly inof_parse_phandle_with_args()

From: Tang Yuantian-B29983
Date: Wed Apr 17 2013 - 00:49:28 EST




> -----Original Message-----
> From: Timur Tabi [mailto:timur@xxxxxxxx]
> Sent: 2013年4月17日 11:31
> To: Tang Yuantian-B29983
> Cc: Grant Likely; devicetree-discuss; linuxppc-dev@xxxxxxxxxxxxxxxx; lkml;
> Rob Herring
> Subject: Re: [PATCH v2] of/base: release the node correctly in
> of_parse_phandle_with_args()
>
> Tang Yuantian-B29983 wrote:
> >> >On Tue, Apr 9, 2013 at 10:36 PM,<Yuantian.Tang@xxxxxxxxxxxxx> wrote:
> >>> > >
> >>> > >+ /* Found it! return success */
> >> >
> >> >I'm pretty sure this comment is in the wrong place.
>
> > It is not perfect, but acceptable.
>
> Like I said, I'm pretty sure it's in the wrong place.
>

It was placed on ELSE statement originally, I moved it to IF statement.
Why is it so wrong?

Thanks,
Yuantian
N?叉??y??b??千v??藓{.n???{?赙zXФ?塄}?财??j:+v???赙zZ+€?zf"?????i????ア??璀??撷f?^j谦y??@A?囤?0鹅h??i