Re: [PATCH v3 5/5] mutex: Move mutex spinning code from sched/core.cback to mutex.c

From: Ingo Molnar
Date: Wed Apr 17 2013 - 03:18:37 EST



* Waiman Long <Waiman.Long@xxxxxx> wrote:

> As mentioned by Ingo, the SCHED_FEAT_OWNER_SPIN scheduler feature
> bit was really just an early hack to make with/without mutex-spinning
> testable. So it is no longer necessary.
>
> This patch removes the SCHED_FEAT_OWNER_SPIN feature bit and move the
> mutex spinning code from kernel/sched/core.c back to kernel/mutex.c
> which is where they should belong.
>
> Signed-off-by: Waiman Long <Waiman.Long@xxxxxx>
> ---
> include/linux/sched.h | 4 ---
> kernel/mutex.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++
> kernel/sched/core.c | 63 -----------------------------------------------
> kernel/sched/features.h | 7 -----
> 4 files changed, 62 insertions(+), 74 deletions(-)

Please move this patch first in the series - so that later, functional patches are
easier to revert, should the need arise. When possible we sort patches by risk:
low risk ones first, riskier come later.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/