Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched

From: James Hogan
Date: Wed Apr 17 2013 - 05:13:31 EST


On 17/04/13 05:13, Vineet Gupta wrote:
> Hi James,
>
> On 04/16/2013 09:23 PM, James Hogan wrote:
>> On 12/04/13 22:52, Stephen Warren wrote:
>>> +.SECONDARY: $(obj)/$(builtindtb-y).dtb.S
>> Note, this may not work if you're using CONFIG_ARC_BUILTIN_DTB_NAME,
>> since it'll have quotes around it, so you may instead need:
>> .SECONDARY: $(obj)/$(patsubst "%",%,$(builtindtb-y)).dtb.S
>>
>> (at least that's what's required for the metag equivalent)
>>
>>> +
>>> dtbs: $(addprefix $(obj)/, $(builtindtb-y).dtb)
>> You might find the same thing here too.
>
> Actually in my Makefile, the quotes are stripped off in the very beginning to
> avoid duplicating it in every place.
>
> ifneq ($(CONFIG_ARC_BUILTIN_DTB_NAME),"")
> builtindtb-y := $(patsubst "%",%,$(CONFIG_ARC_BUILTIN_DTB_NAME))
> endif

Ah yes, I didn't notice that difference. I'll do the same thing for
metag (it only had 1 reference to it before).

Thanks
James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/