Re: [PATCH] usb: storage: Add usb_stor_dbg, reduce object size

[Alan Stern]

On Tue, 16 Apr 2013, Joe Perches wrote:

> Reduce the size of the objects by consolidating
> the duplicated USB_STORAGE into a single function.
> 
> Add function usb_stor_dbg to emit debugging messages.
> Always validate the format and arguments.
> Reduce the number of uses of CONFIG_USB_STORAGE_DEBUG.
> 
> Reduces size of objects ~7KB when CONFIG_USB_STORAGE_DEBUG
> is set.
> 
> $ size drivers/usb/storage/built-in.o*
>    text	   data	    bss	    dec	    hex	filename
>  140133	  55296	  70312	 265741	  40e0d	drivers/usb/storage/built-in.o.new
>  147494	  55248	  70296	 273038	  42a8e	drivers/usb/storage/built-in.o.old
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Is there any reasonable way to change this so that US_DEBUGP gets
converted to a dev_dbg call instead of a printk call?  Not including
the device identifier in the output can be a real problem if there are
multiple mass-storage devices in the system.

Alan Stern


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/