Re: [NEW DRIVER V5 7/7] drivers/regulator: DA9058 REGULATOR driver

[Mark Brown]

On Wed, Apr 17, 2013 at 05:33:37PM +0100, Anthony Olech wrote:

> +	reg->init.constraints.name = rpdata->regulator_name;
> +	reg->init.constraints.min_uv = rpdata->min_uv;
> +	reg->init.constraints.max_uv = rpdata->max_uv;
> +	reg->init.constraints.valid_ops_mask = rpdata->valid_ops_mask;
> +	reg->init.constraints.valid_modes_mask = rpdata->valid_modes_mask;
> +	reg->init.constraints.boot_on = rpdata->boot_on;
> +	reg->init.constraints.always_on = rpdata->always_on;
> +	reg->init.num_consumer_supplies = rpdata->num_consumer_supplies;
> +	reg->init.consumer_supplies = rpdata->consumer_supplies;

Just embed a regulator_init_data or pointer to one in the platform data,
the driver should not need to care about the contents - think what
happens if we add new features to the API...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/