Re: [PATCH v2] kernel: audit_tree: resource management: need put_treeand goto Err when failure occures

[Chen Gang F T]

On 2013å04æ18æ 04:07, Andrew Morton wrote:
> On Wed, 17 Apr 2013 12:04:02 +0800 Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> 
>> >   since "normally audit_add_tree_rule() will free it on failure",
>> >   need free it completely, when failure occures.
>> > 
>> >     need additional put_tree before return, since get_tree was called.
>> >     always need goto error processing area for list_del_init.
> Isn't that get_tree() in audit_add_tree_rule() simply unneeded?  In
> other words, is this patch correct:
> 

  excuse me:
    I am not quite familiar with it, and also have to do another things.
    so I have to spend additional time resource to make sure about it.

  is it ok ?
    I should make sure about it within this week (2013-04-21)
    I should finish related test (if need), within next week (2013-4-28)

  if have additional suggestions or completions, please reply.
    (if no reply, I will follow the time point above)

  thanks.

gchen.


> --- a/kernel/audit_tree.c~a
> +++ a/kernel/audit_tree.c
> @@ -682,7 +682,6 @@ int audit_add_tree_rule(struct audit_kru
>  		goto Err;
>  	}
>  
> -	get_tree(tree);
>  	err = iterate_mounts(tag_mount, tree, mnt);
>  	drop_collected_mounts(mnt);
>  
> @@ -703,7 +702,6 @@ int audit_add_tree_rule(struct audit_kru
>  		return -ENOENT;
>  	}
>  	rule->tree = tree;
> -	put_tree(tree);
>  
>  	return 0;
>  Err:
> _
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


-- 
Chen Gang

Flying Transformer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/