Re: [RFC PATCH] perf: Update event buffer tail when overwriting oldevents

[Peter Zijlstra]

On Mon, 2013-04-15 at 14:02 +0800, Yan, Zheng wrote:
> From: "Yan, Zheng" <zheng.z.yan@xxxxxxxxx>
> 
> If perf event buffer is in overwrite mode, the kernel only updates
> the data head when it overwrites old samples. The program that owns
> the buffer need periodically check the buffer and update a variable
> that tracks the date tail. If the program fails to do this in time,
> the data tail can be overwritted by new samples. The program has to
> rewind the buffer because it does not know where is the first vaild
> sample.
> 
> This patch makes the kernel update the date tail when it overwrites
> old events. So the program that owns the event buffer can always
> read the latest samples. This is convenient for programs that use
> perf to do branch tracing. For example, debugger may want to know
> the latest branches before the ptrace event, but it doesn't care
> about old branchs samples.

The reason I've never done this is because it makes the fast path more
complex and expensive for arguably a corner case.

So if we're going to do this, you need strong arguments for why its
useful (this includes people actually using this etc..) and performance
data showing the impact of this change.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/