Re: [PATCH] usb: storage: Add usb_stor_dbg, reduce object size

[Alan Stern]

On Wed, 17 Apr 2013, Joe Perches wrote:

> On Wed, 2013-04-17 at 14:47 -0400, Alan Stern wrote:
> > On Wed, 17 Apr 2013, Joe Perches wrote:
> []
> > > +int usb_stor_dbg(const struct us_data *us, const char *fmt, ...)
> > > +{
> > > +     struct va_format vaf;
> > > +     va_list args;
> > > +     int r;
> > > +
> > > +     va_start(args, fmt);
> > > +
> > > +     if (us && us->pusb_dev) {
> > > +             r = dev_vprintk_emit(7, &us->pusb_dev->dev, fmt, args);
> > 
> > Isn't there a symbolic constant you can use instead of "7"?
> 
> Nope.
> lib/dynamic_debug:__dynamic_dev_dbg() does the same thing.

This clearly is an omission in the logging API.

Kay, why doesn't the kernel have symbolic constants for the various
logging facilities and levels?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/