Re: [PATCH 11/12] si476x: Fix some config dependencies and a compilewarnings

[Samuel Ortiz]

On Thu, Apr 18, 2013 at 09:58:37AM -0700, Andrey Smirnov wrote:
> From: Hans Verkuil <hverkuil@xxxxxxxxx>
> 
> radio-si476x depends on SND and SND_SOC, the mfd driver should select
> REGMAP_I2C.
> 
> Also fix a small compile warning in a debug message:
> 
> drivers/mfd/si476x-i2c.c: In function âsi476x_core_drain_rds_fifoâ:
> drivers/mfd/si476x-i2c.c:391:4: warning: field width specifier â*â expects argument of type âintâ, but argument 4 has type âlong unsigned intâ [-Wformat]
> 
> Acked-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
>  drivers/media/radio/Kconfig |    2 +-
>  drivers/mfd/Kconfig         |    1 +
>  drivers/mfd/si476x-i2c.c    |    2 +-
You should have merged the MFD bits from this patch into one of the first 4
patches, that are MFD related. Or at least separated those 2 changes into 2
patches...

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/