Re: [PATCH 1/5] ARM: at91: at91sam9x5 RTC is not compatible withat91rm9200 one

[Nicolas Ferre]

On 04/19/2013 03:53 PM, Sergei Shtylyov :
> Hello.
> 
> On 18-04-2013 17:01, Nicolas Ferre wrote:
> 
>> Due to a bug with RTC IMR, we cannot consider at91sam9x5 RTC compatible
>> with the previous one. Modify DT compatibility string, even if the driver
>> is not yet modified to take it into account.
> 
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
>> ---
>>   arch/arm/boot/dts/at91sam9x5.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi
>> b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index a3d4464..58747f3 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -564,7 +564,7 @@
>>               };
>>
>>               rtc@fffffeb0 {
>> -                compatible = "atmel,at91rm9200-rtc";
>> +                compatible = "atmel,at91sam9x5-rtc";
> 
>    Do not use wildcards in the "compatible" prop values (I guess 'x' is
> a wildcard).

Well, it is for naming a series of hardware, not for giving a generic
name that could cover different hardware.

In the sense of Atmel it is our way to call the at91sam9x5 series of
SoC: you will see that the code that covers these SoCs is always named
like this.
In fact, the hardware contained in these SoC cannot be different from
one flavor of the family to the other.

Best regards,
-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/