Re: Re: [PATCH] I2C: Change the value of octeon i2c adapter timeoutvalue

From: Wolfram Sang
Date: Fri Apr 19 2013 - 14:33:06 EST


On Fri, Apr 19, 2013 at 09:13:54AM +0000, EUNBONG SONG wrote:
>
>
> On Fri, Apr 19, 2013 at 12:01:04AM +0000, EUNBONG SONG wrote:
> >>
> >> I think HZ/50 is better than 2 for adapter timeout.
>
> > Basically OK. But why HZ/50? Most drivers use HZ.
>
> Actually, I just translated 2 jiffies because HZ is 100 in default cavium config.
> You can find that in "arch/mips/configs/cavium_octeon_defconfig".
> And i have been using this value over 1 year in octeon board without problem.

Have you been writing to EEPROMS? Their erase/write cycle might be
longer. But I am not forcing you to change the value, just giving some
suggestions.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/