Re: [PATCH] x86: Add check for P5 to microcode_intel_early

[Bryan O'Donoghue]

On 19/04/13 22:25, Borislav Petkov wrote:
> On Fri, Apr 19, 2013 at 10:55:15PM +0200, Borislav Petkov wrote:
> > Just filter out P5 and earlier. The code already does that for CPUs
> > which don't have CPUID.
>
> Actually, an alternative - more practical albeit not very accurate

More practical ? Hmm - the MSRs don't exist for < P5

> solution would be to check for which families Intel delivers microcode
> and do the cut off there with a comment as to why you do it like that.void

You mean return !intel so this function will never be called.

__init load_ucode_bsp(void)
{
        int vendor = x86_vendor();

        if (vendor == X86_VENDOR_INTEL)
                load_ucode_intel_bsp();
}

Ah yes. That would work and be less code.

We should do it that way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/