Re: [PATCH 1/5] perf: Add hardware breakpoint address mask

[Oleg Nesterov]

On 04/09, Jacob Shin wrote:
>
> @@ -612,6 +612,9 @@ static int hw_breakpoint_add(struct perf_event *bp, int flags)
>  	if (!(flags & PERF_EF_START))
>  		bp->hw.state = PERF_HES_STOPPED;
>
> +	if (bp->attr.bp_addr_mask && !arch_has_hw_breakpoint_addr_mask())
> +		return -EOPNOTSUPP;
> +

This is called by sched_in... Isn't it "too late" ?

Perhaps arch_validate_hwbkpt_settings() should validate mask/cpu_has_bpext?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/