Re: [RESEND][PATCH] ARM: PL011: add support for extended FIFO-sizeof PL011-r1p5

[Russell King - ARM Linux]

On Sat, Apr 20, 2013 at 03:31:39PM +0200, Linus Walleij wrote:
> static struct amba_id pl011_ids[] = {
>         {
>                 .id     = 0x00341011,
>                 .mask   = 0x00ffffff,
>                 .data   = &vendor_arm_deepfifo,
>         },
> (...)
> };
> 
> As you can see in amba_lookup() in
> drivers/amba/bus.c the table is traversed from the top,
> so for the new "3" variant this entry will match, while the
> next entry will match all older versions.

This isn't equivalent - this will only match variant 3, not any later
ones.  The original patch uses the deep fifo for variant 3 or larger.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/