Re: [PATCH 3/3] ext4: mark metadata blocks using bh flags

From: Theodore Ts'o
Date: Sun Apr 21 2013 - 15:56:34 EST


On Sun, Apr 21, 2013 at 08:09:14AM +0200, Jiri Slaby wrote:
> On 04/21/2013 02:07 AM, Theodore Ts'o wrote:
> > This allows metadata writebacks which are issued via block device
> > writeback to be sent with the current write request flags.
>
> Hi, where do these come from?
> fs/ext4/ext4_jbd2.c: In function â__ext4_handle_dirty_metadataâ:
> fs/ext4/ext4_jbd2.c:218:2: error: implicit declaration of function
> âmark_buffer_metaâ [-Werror=implicit-function-declaration]
> fs/ext4/ext4_jbd2.c:219:2: error: implicit declaration of function
> âmark_buffer_prioâ [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors

They are defined by "[PATCH 2/3] buffer: add BH_Prio and BH_Meta flags" here:

+BUFFER_FNS(Meta, meta)
+BUFFER_FNS(Prio, prio)

When you tried applying this patch, did you try applying all three
patches in the patch series?

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/