Re: [PATCH 2/2] f2fs: add REQ_META about metadata requests for submitbio

[Jaegeuk Kim]

2013-04-20 (í), 01:27 +0900, Namjae Jeon:
> From: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> 
> Adding REQ_META for all the metadata requests can help in improving the
> FS performance, if the underlying device supports TAGGING.
> So, when considering the submit_bio path for all the f2fs requests. We can
> add REQ_META for all the META requests.
> As a precursor to this change we considered the commit
> 4265900e0be653f5b78baf2816857ef57cf1332f 'mmc: MMC-4.5 Data Tag Support'
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
> Signed-off-by: Amit Sahrawat <a.sahrawat@xxxxxxxxxxx>
> ---
>  fs/f2fs/segment.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 1193a26..a2e5de7 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -689,6 +689,9 @@ static void do_submit_bio(struct f2fs_sb_info *sbi,
>  	if (type >= META_FLUSH)
>  		rw = WRITE_FLUSH_FUA;
>  
> +	if (type == META)

Should be if (btype == META).
Thanks,

> +		rw |= REQ_META;
> +
>  	if (sbi->bio[btype]) {
>  		struct bio_private *p = sbi->bio[btype]->bi_private;
>  		trace_f2fs_do_submit_bio(sbi->sb, btype, sync,

-- 
Jaegeuk Kim
Samsung

Attachment: signature.asc
Description: This is a digitally signed message part