Re: [PATCH 21/32] dmaengine: ste_dma40: Also report the number oflogical channels

[Lee Jones]

On Mon, 22 Apr 2013, Vinod Koul wrote:

> On Thu, Apr 18, 2013 at 11:12:03AM +0100, Lee Jones wrote:
> > Now we know the total of physical and logical channels, we may as
> > well report them within the information log.
> > 
> > Before:
> > dma40 dma40.0: hardware revision: 3 @ 0x801c0000 with 8 physical channels
> > 
> > After:
> > <as above ...> and 256 logical channels
> > 
> > Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
> > Cc: Dan Williams <djbw@xxxxxx>
> > Cc: Per Forlin <per.forlin@xxxxxxxxxxxxxx>
> > Cc: Rabin Vincent <rabin@xxxxxx>
> > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > ---
> >  drivers/dma/ste_dma40.c |    5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> > index 282dd59..805049c 100644
> > --- a/drivers/dma/ste_dma40.c
> > +++ b/drivers/dma/ste_dma40.c
> > @@ -3200,8 +3200,9 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
> >  
> >  	num_log_chans = num_phy_chans * D40_MAX_LOG_CHAN_PER_PHY;
> >  
> > -	dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with %d physical channels\n",
> > -		 rev, res->start, num_phy_chans);
> > +	dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with "
> > +		"%d physical channels and %d logical channels\n",
> > +		rev, res->start, num_phy_chans, num_log_chans);
> Splitting log messages across lines is bad idea and sacrifces readablity... also
> wasnt splitting logging to multiple lines emit checkpatch warn

You also get a check-patch error if your lines are over 80 chars.

How would you solve this?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/