Re: [BUG] staging: android: ashmem: Deadlock during ashmem_shrink

From: Dan Carpenter
Date: Mon Apr 22 2013 - 10:22:32 EST


Read Al's email again: https://lkml.org/lkml/2013/3/20/458

I don't know much about VFS locking, but the ashmem locking seems
pretty bogus to me. Why can't multiple threads read() at the same
time?

One thing is that it should probably be broken into different locks
instead of a mini-BKL. Instead of taking a bad design and trying to
hack it until it doesn't crash I think it would be better to redo
the locking from scratch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/