Re: Preemptable Ticket Spinlock

From: Chegu Vinod
Date: Mon Apr 22 2013 - 16:54:45 EST


On 4/22/2013 1:50 PM, Jiannan Ouyang wrote:
On Mon, Apr 22, 2013 at 4:44 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
On Mon, 2013-04-22 at 16:32 -0400, Rik van Riel wrote:
IIRC one of the reasons was that the performance improvement wasn't
as obvious. Rescheduling VCPUs takes a fair amount of time, quite
probably more than the typical hold time of a spinlock.
IIRC it would spin for a while before blocking..

/me goes re-read some of that thread...

Ah, its because PLE is curing most of it.. !PLE it had huge gains but
apparently nobody cares about !PLE hardware anymore :-)

For now, I don't know how good it can work with PLE. But I think it
should save the time of VMEXIT on PLE machine.
.

Thanks for sharing your patch. 'am waiting for your v2 patch(es) and then let you any review feedback. Hoping to verify your changes on a large box (PLE enabled) and get back to you with some data...

Thanks
Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/