Re: [PATCH] regulator: tps62360: Fix off-by-one shift for ramp_ctrl

From: Laxman Dewangan
Date: Tue Apr 23 2013 - 02:23:20 EST


On Tuesday 23 April 2013 10:05 AM, Axel Lin wrote:
According to the datasheet[1]

Register 0x06h Description: RmpCtrl (REGISTER ADDRESS: 0x06h Read/Write)
BIT[5..7]:
RMP[2:0] Output voltage ramp timing
D7-D5 Slope
000 32mV/us
001 16mV/us
010 8mV/us
...
110 0.5mV/us
111 0.25mV/us

Thus to get correct ramp_ctrl value, we need to right-shift 5 bits.

[1] http://www.ti.com/lit/ds/symlink/tps62360.pdf


Checked with my latest and it is correct.
Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/