Re: [PATCH v2] usb: phy: don't mark usb_bind_phy as __init

From: Felipe Balbi
Date: Tue Apr 23 2013 - 15:31:29 EST


On Tue, Apr 23, 2013 at 09:07:21PM +0200, Arnd Bergmann wrote:
> It makes no sense for a symbol to be both exported and marked __init,
> because any users in modules would be calling this function after
> it gets discarded. Further, this patch revolves a section mismatch
> warning from usbhs_init_phys(), which is intentionally not marked
> __init:
>
> WARNING: vmlinux.o(.text+0x413f8): Section mismatch in reference from
> the function usbhs_init_phys() to the function .init.text:usb_bind_phy()
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> ---
>
> v2: rebased on linux-next

not needed, Greg already has a patch doing exactly this in usb-next.

--
balbi

Attachment: signature.asc
Description: Digital signature