Re: [PATCH 05/14] perf tools: Introduce new 'ftrace' tool

From: Jiri Olsa
Date: Wed Apr 24 2013 - 10:09:40 EST


On Tue, Apr 23, 2013 at 05:31:03PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>

SNIP

> +out:
> + put_tracing_file(file);
> + return ret;
> +}
> +
> +static int reset_tracing_files(struct perf_ftrace *ftrace __maybe_unused)
> +{
> + if (write_tracing_file("tracing_on", "0") < 0)
> + return -1;
> +
> + if (write_tracing_file("current_tracer", "nop") < 0)
> + return -1;
> +
> + if (write_tracing_file("set_ftrace_pid", " ") < 0)
> + return -1;

I think we want to reset set_ftrace_pid file as well
probably to -1..

if I'm tracing command with this file having wrong CPU(s)
I dont get any data..

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/