Re: [PATCH] re-order CONFIG_EXPERT options to fix menuconfigdisplay

From: Andrew Morton
Date: Wed Apr 24 2013 - 16:04:49 EST


On Mon, 22 Apr 2013 13:39:38 -0400 Mike Frysinger <vapier@xxxxxxxxxx> wrote:

> The kconfig language requires that dependent options all follow the
> menuconfig symbol in order to be collapsed below it. Recently some
> hidden options were added below the EXPERT menuconfig, but did not
> depend on EXPERT (because hidden options can't). This broke the
> display. So re-order all these options, and while we're here stick
> the PCI quirks under the EXPERT menu (since it isn't sitting with
> any related options).
>
> Before this commit, we get:
> [*] Configure standard kernel features (expert users) --->
> [ ] Sysctl syscall support
> [*] Load all symbols for debugging/ksymoops
> ...
> [ ] Embedded system
>
> Now we get the older (and correct) behavior:
> [*] Configure standard kernel features (expert users) --->
> [ ] Embedded system
> And if you go into the expert menu you get the expert options:
> [ ] Sysctl syscall support
> [*] Load all symbols for debugging/ksymoops
> ...
>

This doesn't work as advertised when I graft it on top of
http://ozlabs.org/~akpm/mmots/broken-out/init-kconfig-make-expert-as-config-instead-of-menuconfig.patch
(generally, assuming that next==mainline when we're at -rc8 is a low
percentage move).

I think I'll drop
init-kconfig-make-expert-as-config-instead-of-menuconfig.patch and take
this one, but could everyone please review everything?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/