Re: [PATCH 17/32] dmaengine: ste_dma40: Remove redundant argumentfrom d40_phy_cfg()

[Linus Walleij]

On Mon, Apr 22, 2013 at 12:18 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:

>> > +   if ((cfg->dir ==  STEDMA40_PERIPH_TO_MEM) ||
>> > +       (cfg->dir == STEDMA40_PERIPH_TO_PERIPH)) {
>>
>> Why would you need your own direction defines, I see that there is not much
>> diff between these and what dmaengine defines, so perhpas you could use
>> those?
>
> I agree. I'll speak to the STE folk.

This is because the driver was written before the dmaengine had
the enum dma_transfer_direction.

A simple search-and-replace patch would do the trick...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/