Re: [ PATCH ] Memory leak fix for bug 57101.

[Li Zefan]

On 2013/4/25 18:05, Anurup m wrote:
> Hi All,
> 
> There is a kernel memory leak observed when the proc file /proc/fs/fscache/stats is read.
> The reason is that in fscache_stats_open, single_open is called and respective release function is not called during release.
> Hence fix with correct release function - single_release. The patch is as below
> 

The fix is obviously corect, but the patch is mangled so you should configure your
email client properly. Read Documention/email-clients.txt.

And when you've done that, remember Cc maintainers when you resend this patch, i.e.
David Howells <dhowells@xxxxxxxxxx> and Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
in this case.

> diff -uprN -X linux-3.9-rc8-vanilla/Documentation/dontdiff linux-3.9-rc8-vanilla/fs/fscache/stats.c linux-3.9-rc8.mod/fs/fscache/stats.c 
> --- linux-3.9-rc8-vanilla/fs/fscache/stats.c        2013-04-22 03:08:45.000000000 +0530 
> +++ linux-3.9-rc8.mod/fs/fscache/stats.c        2013-04-24 23:03:31.531296160 +0530 
> @@ -287,5 +287,5 @@ const struct file_operations fscache_sta 
>          .open                = fscache_stats_open, 
>          .read                = seq_read, 
>          .llseek                = seq_lseek, 
> -        .release        = seq_release, 
> +        .release        = single_release, 

Look the tab was replaced with spaces.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/