Re: [PATCH] mm, highmem: remove useless virtual variable inpage_address_map

[Andrew Morton]

On Mon, 22 Apr 2013 17:26:28 +0900 Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> wrote:

> We can get virtual address without virtual field.
> So remove it.
> 
> ...
>
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -320,7 +320,6 @@ EXPORT_SYMBOL(kunmap_high);
>   */
>  struct page_address_map {
>  	struct page *page;
> -	void *virtual;
>  	struct list_head list;
>  };
>  
> @@ -362,7 +361,10 @@ void *page_address(const struct page *page)
>  
>  		list_for_each_entry(pam, &pas->lh, list) {
>  			if (pam->page == page) {
> -				ret = pam->virtual;
> +				int nr;
> +
> +				nr = pam - page_address_map;

Doesn't compile.  Presumably you meant page_address_maps.

I'll drop this - please resend if/when it has been runtime tested.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/