Re: Basic perf PMU support for Haswell v11

From: Ingo Molnar
Date: Fri Apr 26 2013 - 02:59:34 EST

* Ingo Molnar <mingo@xxxxxxxxxx> wrote:

> You say it's barebones, yet it does not work :-( How well was this
> patch-set tested on non-Haswell hardware, which makes up 99.99% of our
> installed base?
> In particular, after applying your patches, 'perf top' stopped working
> on an Intel testbox of mine:

The other problem I noticed was stylistic: when I applied your patches for
testing even Git complained about their cleanliness ...

To quote from Documentation/SubmittingPatches:

4) Style check your changes.

Check your patch for basic style violations, details of which can be
found in Documentation/CodingStyle. Failure to do so simply wastes
the reviewers time and will get your patch rejected, probably
without even being read.

At a minimum you should check your patches with the patch style
checker prior to submission (scripts/ You should
be able to justify all violations that remain in your patch.

Please make your patches less sloppy!


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at